-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intl API timezone guessing logs an error in a valid case #324
Comments
Correct. Note that this was because in 1.0 of the Intl spec, time zone support was considered optional. In the current 2.0 version, it's mandatory. So |
+1 |
2 similar comments
+1 |
+1 |
+1. please fix it |
+1 |
3 similar comments
+1 |
+1 |
+1 |
This has been fixed in |
I'm using |
I am also getting the error using |
@alex88 @sagarguhe - Sorry, didn't see this earlier. I think maybe you actually don't have the data loaded? If not, please let me know specifically which browser and OS this is occurring on please. Also, a JSFiddle would be useful. |
@mj1856 yeah I've solved that, I don't remember how though :) Probably I was importing the wrong package without the tz data |
Currently the
rebuildGuess
function logs an error when Intl API guessing did not succeed:logError("Moment Timezone found " + intlName + " from the Intl api, but did not have that data loaded.");
It is however a valid case when Intl API returns an undefined value, see note in ECMA Standard:
rebuildGuess
function should most likely be fixed not to treat undefined value from Intl API as error, but instead let the function continue with the non-Intl execution.The text was updated successfully, but these errors were encountered: