[subscriptions] custom onConnect

[AndreMaz]

I think I found a small issue when passing a custom onConnect middleware. The default onConnect looks like this

moleculer-apollo-server/src/service.js

Lines 656 to 659 in 2463499

	subscriptions: {
	onConnect: (connectionParams, socket) =>
	this.actions.ws({ connectionParams, socket }),
	},

which simply calls the ws action to set the params

moleculer-apollo-server/src/service.js

Lines 32 to 50 in 2463499

	ws: {
	timeout: 0,
	visibility: "private",
	tracing: {
	tags: {
	params: ["socket.upgradeReq.url"],
	},
	spanName: ctx => `UPGRADE ${ctx.params.socket.upgradeReq.url}`,
	},
	handler(ctx) {
	const { socket, connectionParams } = ctx.params;
	return {
	$ctx: ctx,
	$socket: socket,
	$service: this,
	$params: { body: connectionParams, query: socket.upgradeReq.query },
	};
	},
	},

However, when passing custom onConnect I can't access the ws action because the this points to a SubscriptionServer instead of moleculer Service.

To solve it I've added the following lines in the created() function:

if (_.isFunction(mixinOptions.serverOptions.subscriptions.onConnect)){
    mixinOptions.serverOptions.subscriptions.onConnect = mixinOptions.serverOptions.subscriptions.onConnect.bind(this)
}

@Hugome can you please check if my approach is correct?

[icebob]

Maybe it's related #75

[AndreMaz]

You're right, it's definitely related. @shawnmcknight do you have any thoughts on this?

[AndreMaz]

Note: with this approach we continue to have access to the SubscriptionServer

[AndreMaz]

@Hugome @shawnmcknight sorry to bother you again but do you have any thoughts about this?