Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure by configuring and upgrading editorconfig #435

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

VonUniGE
Copy link
Contributor

Running mvn clean package on master branch gives errors:

[ERROR] src/it/update-file-header-test-mojo/src/files/properties/test.crlf.sh@1,10: Insert cr - violates end_of_line = crlf, reported by org.ec4j.linters.TextLinter
[ERROR] src/it/update-file-header-test-mojo/src/files/properties/test.crlf.sh@2,1: Insert cr - violates end_of_line = crlf, reported by org.ec4j.linters.TextLinter

For some reasons the file https://github.com/mojohaus/license-maven-plugin/blob/master/src/it/update-file-header-test-mojo/src/files/properties/.editorconfig is not taken into account.

In this commit:

  • Remove the .editorconfig file in /src/it/update-file-header-test-mojo/src/files/properties
  • Added its rule in the main .editorconfig
  • Upgrade editorconfig-maven-plugin from 0.0.10 to 0.1.1

The master branch now builds.

@slachiewicz slachiewicz merged commit 9fcd94e into mojohaus:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants