-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #277 aggregate-add-third-party does not use missingFileUrl parameter #280
Conversation
9ec804d
to
d18baf0
Compare
Hello @ppalaga, let me know if fix is as your expectation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elballa thanks, looks quite good. Could you please do the following to make sure that we are not breaking the missingFile
param?
Create three separate executions in src/it/aggregate-add-third-party-missing-file/pom.xml
(much like we do in
license-maven-plugin/src/it/add-third-party-missing-file/pom.xml
Lines 88 to 109 in 87489be
<execution> | |
<id>by-classpath</id> | |
<phase>generate-resources</phase> | |
<goals> | |
<goal>add-third-party</goal> | |
</goals> | |
<configuration> | |
<missingFileUrl>classpath:missing-licenses.properties</missingFileUrl> | |
<thirdPartyFilename>THIRD-PARTY-by-classpath.txt</thirdPartyFilename> | |
</configuration> | |
</execution> | |
<execution> | |
<id>by-file</id> | |
<phase>generate-resources</phase> | |
<goals> | |
<goal>add-third-party</goal> | |
</goals> | |
<configuration> | |
<missingFileUrl>file:///${basedir}/missing-licenses.properties</missingFileUrl> | |
<thirdPartyFilename>THIRD-PARTY-by-file.txt</thirdPartyFilename> | |
</configuration> | |
</execution> |
- First:
missingFileUrl
set,missingFile
not set - this is actually what you have there now - Second:
missingFileUrl
not set,missingFile
set - Third: both
missingFileUrl
andmissingFile
set -the entries should get merged as documentedmissingFileUrl
's JavaDoc.
You'll probably need to add one more dependency to have at least one for each of missingFileUrl
and missingFile
. org.json:json:20070829
might be a good candidate.
b402650
to
df10fda
Compare
Integration test reproducing the issue
…l parameter Fix mojohaus#284 missingFile property in aggregate-add-third-party is always overrided by the aggregateMissingLicensesFile
We created three integration tests as you asked for. |
Replaced by #286 |
Integration test reproducing the issue