Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #277 aggregate-add-third-party does not use missingFileUrl parameter #280

Closed
wants to merge 2 commits into from

Conversation

elballa
Copy link

@elballa elballa commented Feb 21, 2019

Integration test reproducing the issue

@elballa elballa force-pushed the feature/277 branch 2 times, most recently from 9ec804d to d18baf0 Compare February 21, 2019 14:40
@elballa
Copy link
Author

elballa commented Feb 21, 2019

Hello @ppalaga, let me know if fix is as your expectation

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elballa thanks, looks quite good. Could you please do the following to make sure that we are not breaking the missingFile param?

Create three separate executions in src/it/aggregate-add-third-party-missing-file/pom.xml (much like we do in

<execution>
<id>by-classpath</id>
<phase>generate-resources</phase>
<goals>
<goal>add-third-party</goal>
</goals>
<configuration>
<missingFileUrl>classpath:missing-licenses.properties</missingFileUrl>
<thirdPartyFilename>THIRD-PARTY-by-classpath.txt</thirdPartyFilename>
</configuration>
</execution>
<execution>
<id>by-file</id>
<phase>generate-resources</phase>
<goals>
<goal>add-third-party</goal>
</goals>
<configuration>
<missingFileUrl>file:///${basedir}/missing-licenses.properties</missingFileUrl>
<thirdPartyFilename>THIRD-PARTY-by-file.txt</thirdPartyFilename>
</configuration>
</execution>
)

  • First: missingFileUrl set, missingFile not set - this is actually what you have there now
  • Second: missingFileUrl not set, missingFile set
  • Third: both missingFileUrl and missingFile set -the entries should get merged as documented missingFileUrl 's JavaDoc.

You'll probably need to add one more dependency to have at least one for each of missingFileUrl and missingFile. org.json:json:20070829 might be a good candidate.

@elballa elballa force-pushed the feature/277 branch 2 times, most recently from b402650 to df10fda Compare February 22, 2019 16:21
Integration test reproducing the issue
…l parameter

Fix mojohaus#284 missingFile property in aggregate-add-third-party is always overrided by the aggregateMissingLicensesFile
@elballa
Copy link
Author

elballa commented Feb 22, 2019

We created three integration tests as you asked for.
We found a new problem in using missingFile parameter because it was overrided by default value of deprecated aggregateMissingLicensesFile parameter as explained in the issue #284. So we also provided the solution of that issue by removing the assignment of the default value.

@ppalaga
Copy link
Contributor

ppalaga commented Feb 23, 2019

Replaced by #286

@ppalaga ppalaga closed this Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants