-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #282 Better document include* and exclude* parameters in AbstractAddThirdPartyMojo #273
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -113,90 +113,147 @@ public abstract class AbstractAddThirdPartyMojo | |
protected boolean acceptPomPackaging; | ||
|
||
/** | ||
* A filter to exclude some scopes. | ||
* <p> | ||
* Multiple scopes can be delimited by comma, eg. {@code <excludedScopes>test,provided</excludedScopes>} | ||
* A comma separated list of scopes to exclude: e.g. {@code <excludedScopes>test,provided</excludedScopes>} | ||
* or {@code -Dlicense.excludedScopes=test,provided}. | ||
* <p> | ||
* This filter is applied on the list of direct dependencies (and | ||
* their transitive dependencies) of the projects in the reactor. | ||
* <p> | ||
* By default if an artifact is excluded its transitive dependencies | ||
* are not automatically excluded. To enforce this behavior refer to | ||
* {@link #excludeTransitiveDependencies}. | ||
* | ||
* @since 1.1 | ||
*/ | ||
@Parameter( property = "license.excludedScopes", defaultValue = "system" ) | ||
protected String excludedScopes; | ||
|
||
/** | ||
* A filter to include only some scopes, if let empty then all scopes will be used (no filter). | ||
* <p> | ||
* Multiple scopes can be delimited by comma, eg. {@code <includedScopes>test,provided</includedScopes>} | ||
* A comma separated list of scopes to include: e.g. {@code <includedScopes>test,provided</includedScopes>} | ||
* or {@code -Dlicense.includedScopes=test,provided}. | ||
* <p> | ||
* This filter is applied on the list of direct dependencies (and | ||
* their transitive dependencies) of the projects in the reactor. | ||
* <p> | ||
* By default if an artifact is included also its transitive | ||
* dependencies are included. To suppress this behavior refer to | ||
* {@link #includeTransitiveDependencies}. | ||
* | ||
* @since 1.1 | ||
*/ | ||
@Parameter( property = "license.includedScopes" ) | ||
protected String includedScopes; | ||
|
||
/** | ||
* A filter to exclude some types. | ||
* A comma separated list of types to exclude: e.g. {@code <excludedTypes>war,pom</excludedTypes>} | ||
* or {@code -Dlicense.excludedTypes=was,pom}. | ||
* <p> | ||
* This filter is applied on the list of direct dependencies (and | ||
* their transitive dependencies) of the projects in the reactor. | ||
* <p> | ||
* By default if an artifact is excluded its transitive dependencies | ||
* are not automatically excluded. To enforce this behavior refer to | ||
* {@link #excludeTransitiveDependencies}. | ||
* | ||
* @since 1.15 | ||
*/ | ||
@Parameter( property = "license.excludedTypes" ) | ||
protected String excludedTypes; | ||
|
||
/** | ||
* A filter to include only some types, if let empty then all types will be used (no filter). | ||
* A comma separated list of types to include. | ||
* <p> | ||
* This filter is applied on the list of direct dependencies (and | ||
* their transitive dependencies) of the projects in the reactor. | ||
* <p> | ||
* By default if an artifact is included also its transitive | ||
* dependencies are included. To suppress this behavior refer to | ||
* {@link #includeTransitiveDependencies}. | ||
* | ||
* @since 1.15 | ||
*/ | ||
@Parameter( property = "license.includedTypes" ) | ||
protected String includedTypes; | ||
|
||
/** | ||
* A filter to exclude some GroupIds | ||
* This is a regular expression that is applied to groupIds (not an ant pattern). | ||
* A regular expression (not glob pattern) used as filter to exclude | ||
* artifacts that have matching groupId. Match could be also partial for | ||
* example {@code ^org\.} | ||
* <p> | ||
* This filter is applied on the list of direct dependencies (and | ||
* their transitive dependencies) of the projects in the reactor. | ||
* <p> | ||
* By default if an artifact is excluded its transitive dependencies | ||
* are not automatically excluded. To enforce this behavior refer to | ||
* {@link #excludeTransitiveDependencies}. | ||
* | ||
* @since 1.1 | ||
*/ | ||
@Parameter( property = "license.excludedGroups" ) | ||
protected String excludedGroups; | ||
|
||
/** | ||
* A filter to include only some GroupIds | ||
* This is a regular expression applied to artifactIds. | ||
* A regular expression (not glob pattern) used as filter to include | ||
* only artifacts that have matching groupId. | ||
* <p> | ||
* This filter is applied on the list of direct dependencies (and | ||
* their transitive dependencies) of the projects in the reactor. | ||
* <p> | ||
* By default if an artifact is included also its transitive | ||
* dependencies are included. To suppress this behavior refer to | ||
* {@link #includeTransitiveDependencies}. | ||
* | ||
* @since 1.1 | ||
*/ | ||
@Parameter( property = "license.includedGroups" ) | ||
*/ @Parameter( property = "license.includedGroups" ) | ||
protected String includedGroups; | ||
|
||
/** | ||
* A filter to exclude some ArtifactsIds | ||
* This is a regular expression applied to artifactIds. | ||
* A regular expression (not glob pattern) used as filter to exclude | ||
* artifacts that have matching artifactId. Match could be also partial for | ||
* example {@code ^org\.} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. {@code ^org.} is perhaps not an ideal example for an artifactId pattern |
||
* <p> | ||
* This filter is applied on the list of direct dependencies (and | ||
* their transitive dependencies) of the projects in the reactor. | ||
* <p> | ||
* By default if an artifact is excluded its transitive dependencies | ||
* are not automatically excluded. To enforce this behavior refer to | ||
* {@link #excludeTransitiveDependencies}. | ||
* | ||
* @since 1.1 | ||
*/ | ||
@Parameter( property = "license.excludedArtifacts" ) | ||
protected String excludedArtifacts; | ||
|
||
/** | ||
* A filter to include only some ArtifactsIds | ||
* This is a regular expression applied to artifactIds. | ||
* A regular expression (not glob pattern) used as filter to include | ||
* only artifacts that have matching artifactId. | ||
* <p> | ||
* This filter is applied on the list of direct dependencies (and | ||
* their transitive dependencies) of the projects in the reactor. | ||
* <p> | ||
* By default if an artifact is included also its transitive | ||
* dependencies are included. To suppress this behavior refer to | ||
* {@link #includeTransitiveDependencies}. | ||
* | ||
* @since 1.1 | ||
*/ | ||
@Parameter( property = "license.includedArtifacts" ) | ||
protected String includedArtifacts; | ||
|
||
/** | ||
* Include transitive dependencies when checking for missing licenses and downloading license files. | ||
* If this is <tt>false</tt>, then only direct dependencies are examined. | ||
* If {@code true} enforces including transitive dependencies of the | ||
* projects in the reactor; otherwise only direct dependencies of the | ||
* reactor projects are considered. | ||
* | ||
* @since 1.1 | ||
*/ | ||
@Parameter( property = "license.includeTransitiveDependencies", defaultValue = "true" ) | ||
boolean includeTransitiveDependencies; | ||
|
||
/** | ||
* Exclude transitive dependencies from excluded Artifacts | ||
* If {@code true} enforces excluding transitive dependencies of the | ||
* excluded artifacts in the reactor; otherwise only artifacts that match | ||
* exclude filters are excluded. | ||
* | ||
* @since 1.13 | ||
*/ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
transitive dependencies