-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
overrideUrl doesn't work #331
Comments
A couple of unit tests under https://github.com/mojohaus/license-maven-plugin/tree/master/src/test/java/org/codehaus/mojo/license would be highly welcome that would cover not only this broken case but also the cases that work properly now. |
Can you please include the fix in 1.21? I tested it locally and without the fix, the functionality is completely broken for us. You can then leave this issue open to add the unit tests later or create another issue for the tests. |
I am ready to review a PR from you and I will require the tests to merge it. The tests are for your own safety, so that it cannot happen that somebody breaks your stuff next day after the fix was merged. Once the PR is merged, I have no problem to release promptly. |
I encountered an issue using overrideUrl with 1.16 which is fixed in 2.0.0 . See mojohaus/license-maven-plugin#331
I encountered an issue using overrideUrl with 1.16 which is fixed in 2.0.0 . See mojohaus/license-maven-plugin#331
There is a bug in the code which processes the overrideUrl in org.codehaus.mojo.license.LicenseMojoUtils.prepareUrl(String, File, String, File, String):
should be
The text was updated successfully, but these errors were encountered: