Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missingFile property in aggregate-add-third-party is always overrided by the aggregateMissingLicensesFile #284

Closed
nfalco79 opened this issue Feb 22, 2019 · 0 comments
Closed

missingFile property in aggregate-add-third-party is always overrided by the aggregateMissingLicensesFile #284

nfalco79 opened this issue Feb 22, 2019 · 0 comments
Milestone
1.18

Comments

@nfalco79
Copy link
Contributor

During the implementation of the integration test for #277 we found other issue.
The aggregate-add-third-party goal in init method overrides the missingFile property value with aggregateMissingLicensesFile if valued.
Since the aggregateMissingLicensesFile has a default value this always happens. This means that any missingFile in pom.xml configuration value is overriden.
This is also the cause of #207
elballa pushed a commit to elballa/license-maven-plugin that referenced this issue Feb 22, 2019
@balessandr
Fix mojohaus#277 aggregate-add-third-party does not use missingFileUr…
4681a8f 
…l parameter

Fix mojohaus#284 missingFile property in aggregate-add-third-party is always overrided by the aggregateMissingLicensesFile
@elballa elballa mentioned this issue Feb 22, 2019
Closed
ppalaga pushed a commit to ppalaga/mojohaus-license-maven-plugin that referenced this issue Feb 23, 2019
@balessandr @ppalaga
Integration test for mojohaus#284
60b3f2f
ppalaga pushed a commit to ppalaga/mojohaus-license-maven-plugin that referenced this issue Feb 23, 2019
@balessandr @ppalaga
Fix mojohaus#284 missingFile property in aggregate-add-third-party is…
d3beb7a 
… always

overrided by the aggregateMissingLicensesFile
ppalaga pushed a commit to ppalaga/mojohaus-license-maven-plugin that referenced this issue Feb 23, 2019
@balessandr @ppalaga
Integration test for mojohaus#284
3489314
@ppalaga ppalaga added this to the 1.18 milestone Feb 23, 2019
@nfalco79 nfalco79 mentioned this issue Feb 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.18
Development

No branches or pull requests
2 participants
@ppalaga @nfalco79