Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node Version on Github Actions #44

Open
MartinPlayon opened this issue Nov 3, 2023 · 2 comments
Open

Update Node Version on Github Actions #44

MartinPlayon opened this issue Nov 3, 2023 · 2 comments

Comments

@MartinPlayon
Copy link
Contributor

The current GitHub actions are using

 - uses: actions/setup-node@v3
        with:
          node-version: 16.x

This version is out of support. The point of discussion is whether to move to 20 or 18.

20 is about to become LTS, but I don't think that most images are there yet. I know that lambdas are only at 18.

@moishinetzer
Copy link
Owner

Feel free to open a PR lets see if CI/CD passes

@MartinPlayon
Copy link
Contributor Author

Using node version 18 or 20 runs fine, and even updating most of the packages to recent versions seems to work fine, but esbuild-css-modules-plugin version 3 causes a build failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants