Add missing validation and lexicon for Roles #16788
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing config property so error messages appear below fields in Create window
smg6511
added
area-lexicons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Added new
authorityExistsmethod for Create/Update processors and related lexicon error message. Also added missingalreadyExiststo Update processor.Why is it needed?
A recent introduction of the requirement for Role Authorities to be unique failed to add specific validation checks and messaging.
How to test
Create and update Roles, attempting to specify already-used names and authority levels. Verify error messaging is clear.
Related issue(s)/PR(s)
Resolves #16784.