Bug #9938: Send sendirect, ccsender and autotext mails only to the first mail address of the comma separated list.

Author: Jako

Diff for: assets/snippets/eform/docs/eform.htm

@@ -155,7 +155,7 @@ <h3>Version 1.4.4.1 - 1.4.4.8</h3>
 				<li>Work around for setting required class on check &amp; radio labels</li>
 				<li>bugfix: If eform attibute is set on multiple check boxes only the last value is set in values list</li>
                 <li>Security fix: Additional sanitization applied after stripslashes is used on fields</li>
-                <li>Security fix: Send ccsender and autotext mails only to the first mail address of the comma separated list.</li>
+                <li>Security fix: Send sendirect, ccsender and autotext mails only to the first mail address of the comma separated list.</li>
 			</ul>
 		<p><br />You can see a more extensive <a href="eform_history.htm">version history here</a>. </p>
 			</div>

Diff for: assets/snippets/eform/docs/eform_history.htm

@@ -146,7 +146,7 @@ <h3>Version 1.4.4.1 - 1.4.4.8</h3>
 				<li>Work around for setting required class on check &amp; radio labels</li>
 				<li>bugfix: If eform attibute is set on multiple check boxes only the last value is set in values list</li>
                 <li>Security fix: Additional sanitization applied after stripslashes is used on fields</li>
-                <li>Security fix: Send ccsender and autotext mails only to the first mail address of the comma separated list.</li>
+                <li>Security fix: Send sendirect, ccsender and autotext mails only to the first mail address of the comma separated list.</li>
 			</ul>
 					<h3>Version 1.4.4</h3>
 					<ul>

Diff for: assets/snippets/eform/eform.inc.php

@@ -457,8 +457,15 @@ function eForm($modx,$params) {
 				//defaults to html so only test sendasText
 				$isHtml = ($sendAsText==1 || strstr($sendAsText,'report'))?false:true;
 
+				# added in 1.4.4.8 - Send sendirect, ccsender and autotext mails only to the first mail address of the comma separated list.
+				if ($fields['email']) {
+					$firstEmail = array_shift(explode(',', $fields['email']));
+				} else {
+					$firstEmail = '';
+				}
+
 				if(!$noemail) {
-					if($sendirect) $to = $fields['email'];
+					if($sendirect) $to = $firstEmail;
 					$mail = new PHPMailer();
 					$mail->IsMail();
 					$mail->CharSet = $modx->config['modx_charset'];
@@ -475,15 +482,8 @@ function eForm($modx,$params) {
 					if(!$mail->send()) return 'Main mail: ' . $_lang['ef_mail_error'] . $mail->ErrorInfo;
 				}
 
-				# added in 1.4.4.8 - Send ccsender and autotext mails only to the first mail address of the comma separated list.
-				if ($fields['email']) {
-					$firstEmail = array_shift(explode(',', $fields['email']));
-				} else {
-					$firstEmail = FALSE;
-				}
-
 				# send user a copy of the report
-				if($ccsender && $firstEmail) {
+				if($ccsender && $firstEmail != '') {
 					$mail = new PHPMailer();
 					$mail->IsMail();
 					$mail->CharSet = $modx->config['modx_charset'];
@@ -500,7 +500,7 @@ function eForm($modx,$params) {
 				# send auto-respond email
 				//defaults to html so only test sendasText
 				$isHtml = ($sendAsText==1 || strstr($sendAsText,'autotext'))?false:true;
-				if ($autotext && $firstEmail) {
+				if ($autotext && $firstEmail != '') {
 					$autotext = formMerge($autotext,$fields);
 					$mail = new PHPMailer();
 					$mail->IsMail();