From e4e29a77ce40f79c5fdaabbeb4f6229b5eeb01f6 Mon Sep 17 00:00:00 2001 From: Jakob Nohe Date: Fri, 28 Feb 2025 17:18:06 +0100 Subject: [PATCH] fix(core): fix broken error handling in getManifestJson Failures in loading the manifest file does not return the actual error, but a useless function reference to plugins. Error handling is not possible. The "err" variable is now passed in as "error". --- packages/runtime-core/src/plugins/snapshot/SnapshotHandler.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/runtime-core/src/plugins/snapshot/SnapshotHandler.ts b/packages/runtime-core/src/plugins/snapshot/SnapshotHandler.ts index da38f2e07c0..5bcd4d99236 100644 --- a/packages/runtime-core/src/plugins/snapshot/SnapshotHandler.ts +++ b/packages/runtime-core/src/plugins/snapshot/SnapshotHandler.ts @@ -310,7 +310,7 @@ export class SnapshotHandler { (await this.HostInstance.remoteHandler.hooks.lifecycle.errorLoadRemote.emit( { id: manifestUrl, - error, + error: err, from: 'runtime', lifecycle: 'afterResolve', origin: this.HostInstance,