build script generator - makes a nonsense parameter

[ghost]

modm/tools/build_script_generator/common.py

Lines 221 to 222 in ae85805

	"-ffile-prefix-map={project_source_dir}=.",
	"-ffile-prefix-map={gccpath}=.",

These flags are build system dependent and not filtered, will always create a useless one.

-ffile-prefix-map==.

[salkinium]

The flags are indeed build system dependent, hence their specialization by the specific build system collector:
https://github.com/modm-io/modm/blob/develop/tools/build_script_generator/cmake/module.lb#L48

[ghost]

Should the specialization then not remove the irrelevant one instead of produce a garbage parameter? It would be the most correct thing to do.

[salkinium]

I don't understand what the issue is. These flags where added in #558 to make the file paths in the debug sections relative to the compiler and project sources. The {gccpath} is computed by the build system, since it differs per OS/user.

[salkinium]

In CMake, it's here: https://github.com/modm-io/modm/blob/develop/tools/build_script_generator/cmake/cmake_scripts/configure-gcc.cmake.in#L77

In SCons here: https://github.com/modm-io/modm/blob/develop/tools/build_script_generator/scons/resources/SConscript.in#L40