Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ili9341 SPI not compiling #483

Closed
mikewolfram opened this issue Sep 26, 2020 · 5 comments · Fixed by #484
Closed

Ili9341 SPI not compiling #483

mikewolfram opened this issue Sep 26, 2020 · 5 comments · Fixed by #484
Labels
bug 🐞 help wanted 🛠

Comments

@mikewolfram
Copy link
Contributor

The Ili9341 doesn't compile for me anymore when using with SPI interface. In extension to my implementation #464 the code in the #437 adds a parallel interface. But the templated constructor prevents from compiling. Also for SPI it expects an argument to the constructor.

Maybe you could have a look into it?
@salkinium
Copy link
Member

cc @asmfreak

@asmfreak
Copy link
Contributor

I'll look into it today.

@asmfreak
Copy link
Contributor

asmfreak commented Sep 26, 2020 •
edited
Loading

It seems, that I've made a mistake in std::enable_if.

@rleh
Copy link
Member

rleh commented Sep 27, 2020

It would be nice to have examples for Ili9341 both with SPI and parallel mode. Thus the error would be noticeable in the CI in the future.

@asmfreak
Copy link
Contributor

Yeah. That were my thought exactly yesterday. I've created an example to. Will try to fix and add a new example.

@asmfreak asmfreak mentioned this issue Sep 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞 help wanted 🛠
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[driver] 🐛 Fix ILI9341 and add SPI example for it asmfreak/modm
4 participants
@salkinium @rleh @asmfreak @mikewolfram