Update puppeteer to version 22.0.0

modernweb-dev · Mar 4, 2024 · 9dd1013 · 9dd1013
1 parent 4e28dbb
commit 9dd1013
Show file tree

Hide file tree

Showing 11 changed files with 1,359 additions and 380 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/browser-logs/package.json b/packages/browser-logs/package.json
@@ -51,6 +51,6 @@
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.1.5",
-    "puppeteer": "^20.0.0"
+    "puppeteer": "^22.0.0"
   }
 }
diff --git a/packages/browser-logs/test/serialize-deserialize.test.ts b/packages/browser-logs/test/serialize-deserialize.test.ts
@@ -14,7 +14,7 @@ describe('serialize deserialize', function () {
   let browser: Browser;
   let page: Page;
   before(async () => {
-    browser = await puppeteer.launch({ headless: 'new' });
+    browser = await puppeteer.launch({ headless: true });
     page = await browser.newPage();
     await page.goto('about:blank');
     await page.evaluate(

diff --git a/packages/dev-server-hmr/package.json b/packages/dev-server-hmr/package.json
@@ -44,6 +44,6 @@
   },
   "devDependencies": {
     "lit-html": "^2.7.3 || ^3.0.0",
-    "puppeteer": "^20.0.0"
+    "puppeteer": "^22.0.0"
   }
 }
diff --git a/packages/dev-server-hmr/test/browser.test.ts b/packages/dev-server-hmr/test/browser.test.ts
@@ -13,13 +13,29 @@ function trackErrors(page: Page) {
     errors.push(error);
   });
   page.on('console', e => {
-    if (e.type() === 'error' || e.type() === 'warning') {
+    if (e.type() === 'error' || e.type() === 'warn') {
       errors.push(e.text());
     }
   });
   return errors;
 }
 
+async function mockFaviconRequests(page: Page) {
+  await page.setRequestInterception(true);
+  page.on('request', request => {
+    if (request.isInterceptResolutionHandled()) {
+      return;
+    }
+
+    if (request.url().endsWith('favicon.ico')) {
+      request.respond({ status: 200 });
+      return;
+    }
+
+    request.continue();
+  });
+}
+
 describe('browser tests', function () {
   this.timeout(5000);
   let browser: Browser;
@@ -82,6 +98,7 @@ describe('browser tests', function () {
     });
     const page = await browser.newPage();
     const errors = trackErrors(page);
+    await mockFaviconRequests(page);
 
     try {
       await page.goto(`${host}/foo.html`);
@@ -114,6 +131,7 @@ describe('browser tests', function () {
     });
     const page = await browser.newPage();
     const errors = trackErrors(page);
+    await mockFaviconRequests(page);
 
     try {
       await page.goto(`${host}/foo.html`);
@@ -192,6 +210,7 @@ describe('browser tests', function () {
     });
     const page = await browser.newPage();
     const errors = trackErrors(page);
+    await mockFaviconRequests(page);
 
     try {
       await page.goto(`${host}/foo.html`);

diff --git a/packages/dev-server/package.json b/packages/dev-server/package.json
@@ -73,6 +73,6 @@
   "devDependencies": {
     "@types/command-line-usage": "^5.0.1",
     "lit-html": "^2.7.3 || ^3.0.0",
-    "puppeteer": "^20.0.0"
+    "puppeteer": "^22.0.0"
   }
 }
diff --git a/packages/test-runner-chrome/package.json b/packages/test-runner-chrome/package.json
@@ -50,7 +50,7 @@
     "@web/test-runner-coverage-v8": "^0.8.0",
     "async-mutex": "0.4.0",
     "chrome-launcher": "^0.15.0",
-    "puppeteer-core": "^20.0.0"
+    "puppeteer-core": "^22.0.0"
   },
   "devDependencies": {
     "@types/istanbul-reports": "^3.0.0",

diff --git a/packages/test-runner-chrome/src/ChromeLauncher.ts b/packages/test-runner-chrome/src/ChromeLauncher.ts
@@ -80,7 +80,7 @@ export class ChromeLauncher implements BrowserLauncher {
 
   launchBrowser(options: PuppeteerNodeLaunchOptions = {}) {
     const mergedOptions: PuppeteerNodeLaunchOptions = {
-      headless: 'new',
+      headless: true,
       ...this.launchOptions,
       ...options,
     };

diff --git a/packages/test-runner-chrome/src/index.ts b/packages/test-runner-chrome/src/index.ts
@@ -1,6 +1,6 @@
 import * as puppeteerCore from 'puppeteer-core';
 import { ChromeLauncher, CreateBrowserContextFn, CreatePageFn } from './ChromeLauncher.js';
-import { PuppeteerNodeLaunchOptions, devices } from 'puppeteer-core';
+import { PuppeteerNodeLaunchOptions, KnownDevices } from 'puppeteer-core';
 
 export interface ChromeLauncherArgs {
   puppeteer?: typeof puppeteerCore;
@@ -10,7 +10,7 @@ export interface ChromeLauncherArgs {
   concurrency?: number;
 }
 
-export { ChromeLauncher, devices, puppeteerCore };
+export { ChromeLauncher, KnownDevices, puppeteerCore };
 
 export function chromeLauncher(args: ChromeLauncherArgs = {}) {
   const {

diff --git a/packages/test-runner-puppeteer/package.json b/packages/test-runner-puppeteer/package.json
@@ -48,10 +48,10 @@
   "dependencies": {
     "@web/test-runner-chrome": "^0.15.0",
     "@web/test-runner-core": "^0.13.0",
-    "puppeteer": "^20.0.0"
+    "puppeteer": "^22.0.0"
   },
   "devDependencies": {
     "@web/test-runner-mocha": "^0.9.0",
-    "puppeteer-core": "^20.0.0"
+    "puppeteer-core": "^22.0.0"
   }
 }
diff --git a/packages/test-runner-puppeteer/src/index.ts b/packages/test-runner-puppeteer/src/index.ts
@@ -1,2 +1,2 @@
 export { puppeteerLauncher } from './puppeteerLauncher.js';
-export { devices } from 'puppeteer';
+export { KnownDevices } from 'puppeteer';