Refactor Priority Function #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyushuo
requested review from
pan-x-c and
yanxi-chen
and removed request for
pan-x-c
Contributor
Summary of ChangesHello @chenyushuo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the priority function system within the buffer storage component. By transitioning from a functional approach to an object-oriented design using abstract base classes, the system gains increased flexibility and maintainability. This change also includes updates to the configuration management, enabling dynamic and user-friendly adjustment of priority function parameters through a Streamlit-based interface. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the priority function handling from simple functions to a more robust class-based approach using an Abstract Base Class. This is a good architectural improvement that enhances extensibility. The changes also include a new UI component for editing priority function arguments, which improves user experience.
I've found one critical bug in the changed code that would prevent the application from running correctly and one medium-severity issue related to error handling. My comments include suggestions to fix these issues.
Additionally, I noticed a potential issue in an unchanged part of the code that is affected by this refactoring. The call to the priority function in AsyncPriorityQueue._put at line 225 appears to use the old argument name (item) instead of the new one (items), which will likely cause a TypeError. Since this line is not in the diff, I cannot add a formal comment, but I highly recommend you check and fix it: priority, put_into_queue = self.priority_fn(items=item).
It also appears that the tests in tests/buffer/queue_test.py have not been updated to reflect these changes. Please update the tests to cover the new class-based implementation and ensure they all pass.
Overall, a great refactoring with a few issues to address before merging.
pan-x-c
reviewed
Oct 27, 2025
Collaborator
Author
|
/unittest-module-buffer |
4 tasks
Summary
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
|
/unittest-all |
pan-x-c
approved these changes
Oct 27, 2025
Summary
Failed Tests
Skipped
Tests
Github Test Reporter by CTRF 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title says.
Checklist
Please check the following items before code is ready to be reviewed.