Add restriction for time. #3790
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikt-ma
reviewed
Dec 4, 2025
|
|
||
| All declared variables are functions of the independent variable \lstinline!time!. | ||
| The variable \lstinline!time! is a built-in variable available in all models and blocks, which is treated as an input variable. | ||
| The name \lstinline!time! is reserved and may not declared in any class. |
Collaborator
There was a problem hiding this comment.
I thought the plan in #1243 (comment) was to make it a keyword? That still sounds like the clean way to do it; just add it to primary in the grammar.
Collaborator
Author
There was a problem hiding this comment.
Yes, that would be the alternative.
I see two minor issues:
- I'm not sure we want it syntax highlighted as a keyword in the specification.
- Describing its attributes (in particular its start-attribute - which may be useful for clocked semantics) becomes a bit messy, but by just stating that it corresponds to a variable defined as:... would likely work.
henrikt-ma
requested changes
Dec 4, 2025
Collaborator
henrikt-ma
left a comment
henrikt-ma
left a comment
There was a problem hiding this comment.
Whatever we do to resolve this, there needs to be some change under \cref{modelica-keywords}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1243