From 4754bd1270d319577765b287b6903d664730649c Mon Sep 17 00:00:00 2001 From: Your Name Date: Tue, 10 Jun 2025 15:05:10 +0000 Subject: [PATCH 1/5] Add error log for client stdio --- src/mcp/client/stdio/__init__.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/mcp/client/stdio/__init__.py b/src/mcp/client/stdio/__init__.py index fce605633..d5c3e3027 100644 --- a/src/mcp/client/stdio/__init__.py +++ b/src/mcp/client/stdio/__init__.py @@ -12,6 +12,9 @@ import mcp.types as types from mcp.shared.message import SessionMessage +import logging + +logger = logging.getLogger(__name__) from .win32 import ( create_windows_process, @@ -149,6 +152,9 @@ async def stdout_reader(): try: message = types.JSONRPCMessage.model_validate_json(line) except Exception as exc: + logger.error( + f"Failed to parse JSONRPC message from server: {line}, exception: {exc}", + ) await read_stream_writer.send(exc) continue From eb003eee6e4d898d37810c52d4194ac37c124324 Mon Sep 17 00:00:00 2001 From: pengwa Date: Fri, 13 Jun 2025 20:50:51 +0800 Subject: [PATCH 2/5] Update src/mcp/client/stdio/__init__.py Co-authored-by: Marcelo Trylesinski --- src/mcp/client/stdio/__init__.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mcp/client/stdio/__init__.py b/src/mcp/client/stdio/__init__.py index d5c3e3027..546c544da 100644 --- a/src/mcp/client/stdio/__init__.py +++ b/src/mcp/client/stdio/__init__.py @@ -152,9 +152,7 @@ async def stdout_reader(): try: message = types.JSONRPCMessage.model_validate_json(line) except Exception as exc: - logger.error( - f"Failed to parse JSONRPC message from server: {line}, exception: {exc}", - ) + logger.exception("Failed to parse JSONRPC message from server") await read_stream_writer.send(exc) continue From b0e257bf20fbfb19a5d081428c4f93192c1c1ba3 Mon Sep 17 00:00:00 2001 From: pengwa Date: Fri, 13 Jun 2025 20:54:45 +0800 Subject: [PATCH 3/5] Update __init__.py --- src/mcp/client/stdio/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mcp/client/stdio/__init__.py b/src/mcp/client/stdio/__init__.py index 45316dd56..e4154fe61 100644 --- a/src/mcp/client/stdio/__init__.py +++ b/src/mcp/client/stdio/__init__.py @@ -1,3 +1,4 @@ +import logging import os import sys from contextlib import asynccontextmanager @@ -12,7 +13,6 @@ import mcp.types as types from mcp.shared.message import SessionMessage -import logging logger = logging.getLogger(__name__) From 5fbede9432eb9949e64d39a27bfd15b4e8b203c2 Mon Sep 17 00:00:00 2001 From: pengwa Date: Fri, 13 Jun 2025 20:58:22 +0800 Subject: [PATCH 4/5] Update __init__.py --- src/mcp/client/stdio/__init__.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mcp/client/stdio/__init__.py b/src/mcp/client/stdio/__init__.py index e4154fe61..a5287f038 100644 --- a/src/mcp/client/stdio/__init__.py +++ b/src/mcp/client/stdio/__init__.py @@ -14,14 +14,14 @@ import mcp.types as types from mcp.shared.message import SessionMessage -logger = logging.getLogger(__name__) - from .win32 import ( create_windows_process, get_windows_executable_command, terminate_windows_process, ) +logger = logging.getLogger(__name__) + # Environment variables to inherit by default DEFAULT_INHERITED_ENV_VARS = ( [ From 85752c2d5435aaf710f8db889e4d36c5d18c1d80 Mon Sep 17 00:00:00 2001 From: "Peng Wang (from Dev Box)" Date: Thu, 18 Sep 2025 11:34:54 +0800 Subject: [PATCH 5/5] remove duplication --- src/mcp/client/stdio/__init__.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mcp/client/stdio/__init__.py b/src/mcp/client/stdio/__init__.py index bb7dd7575..6dc7c89af 100644 --- a/src/mcp/client/stdio/__init__.py +++ b/src/mcp/client/stdio/__init__.py @@ -24,8 +24,6 @@ logger = logging.getLogger(__name__) -logger = logging.getLogger(__name__) - # Environment variables to inherit by default DEFAULT_INHERITED_ENV_VARS = ( [