-
Notifications
You must be signed in to change notification settings - Fork 578
Add back EverythingServer for stdio #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add back EverythingServer for stdio #950
Conversation
Co-authored-by: asklar <[email protected]>
Co-authored-by: asklar <[email protected]>
| <Project Path="samples/EverythingServer/EverythingServer.csproj" /> | ||
| <Project Path="samples/EverythingServer.Core/EverythingServer.Core.csproj" /> | ||
| <Project Path="samples/EverythingServer.Http/EverythingServer.Http.csproj" /> | ||
| <Project Path="samples/EverythingServer.Stdio/EverythingServer.Stdio.csproj" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikekistler, I think you were interested in scenarios where a single server could be used either via stdio or http? IIRC, should we do that in this one rather than having different projects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both patterns are valid and it's useful to illustrate how the core MCP logic can be implemented in a class library and used in either a STDIO or sHTTP server project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, can we make the STDIO server pack itself as a tool that can be run with dnx (including it's library dependency)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to use this server as a sample MCPB-based server. Totally up to y'all if you also want to make it available via dnx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would that be built here? Demonstrating deployment options seems like a good thing to add to the samples, but I'll defer to @mikekistler as I'm new here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should start by adding documentation on what an MCPB-based server is and why you might want one. After that we can talk about adding a sample or updating one to demonstrate that.
Adds back EverythingServer option for stdio as it is still useful.
Motivation and Context
Fixes #889
How Has This Been Tested?
locally tested both in inspector
Breaking Changes
no
Types of changes
Checklist
Additional context