Enable test for #786 #954
Merged
Enable test for #786 #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpaco-aws
reviewed
Mar 17, 2022
Contributor
adpaco-aws
left a comment
adpaco-aws
left a comment
There was a problem hiding this comment.
How does this relate to #791 ?
Contributor
Author
|
I'm not sure. @danielsn? |
celinval
reviewed
Mar 22, 2022
Contributor
There was a problem hiding this comment.
Can you please add a comment to what the expected behavior is?
Contributor
Author
There was a problem hiding this comment.
I turned this into an expected test so that we check for the specific failure, and added a comment.
zhassan-aws
force-pushed
the
iss786-test
branch
from
01f4901 to
90ecd74
Compare
Contributor
Author
adpaco-aws
approved these changes
Apr 12, 2022
Co-authored-by: Adrian Palacios <[email protected]>
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Enable test for #786 which now works correctly since we've integrated a CBMC version that includes the fix to diffblue/cbmc#6631.
Resolved issues:
Resolves #786
Call-outs:
Testing:
How is this change tested?
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.