Remove --visualize and cbmc-viewer call #3302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
reviewed
Jun 28, 2024
Contributor
celinval
left a comment
celinval
left a comment
There was a problem hiding this comment.
Don't forget to remove Python from the setup flow
Contributor
|
@jaisnan Is this PR blocked on anything? |
Contributor
|
I think we decided to deprecate it first, but it should be ready to go. @jaisnan can you please resolve the conflicts so we can merge this? |
This was referenced Nov 5, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 9, 2024
This builds upon @jaisnan's changes in #3302. The PR removes the `--visualize` option and the CBMC viewer from the Kani installation and CI. There is still some room for clean-up, specifically with the python dependency. This can be handled in a separate PR. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Co-authored-by: Jaisurya Nanduri <[email protected]>
Contributor
|
The changes from this PR were included in #3699 which was merged. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current status:
--visualizeflagTodo:
Resolves #
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.