Have global exports be compatible with Web Workers #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assigning to `window` only works in a normal browser environment;
however, Web Workers don't have access to `window`. Instead, the global
object inside Web Workers is `self`.
Browserify ensures that `global` is present to all scripts by creating a
shim reference to it using this logic:
typeof global !== "undefined" ? global :
typeof self !== "undefined" ? self :
typeof window !== "undefined" ? window : {}
Thus, if neither `global` nor `self` were originally present,
`global === window` will be true.
Web Workers compatibility was broken in a81e555.
|
|
|
@dasilvacontin If you're talking about this failure, the same error is present on master:
It's not clear to me whether this error is expected or not. The browser test suite might have fallen out of date since it doesn't seem exercised under CI. |
|
|
danielstjules
added a commit
that referenced
this pull request
Jan 26, 2016
Have global exports be compatible with Web Workers
This was referenced Sep 23, 2018
This was referenced Dec 29, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assigning to
windowonly works in a normal browser environment; however, Web Workers don't have access towindow. Instead, the global object inside Web Workers isself.Browserify already ensures that
globalis present and dereferenced accordingly. It will equal towindowunlessselfis defined.This fixes Web Workers compatibility lost in a81e555 (v2.3.0).
/cc @jbnicolai @ndhoule