fix(browser): failed test icon color #4946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failed test icon is currently incorrectly colored as `#00d6b2` instead of `#cc0000` (light schema) or `#ff4444` (dark schema). To fix this, ensure that the correct var is referenced.
|
|
juergba
added
area: browser
juergba
added
the
run-browser-test
github-actions
bot
removed
the
run-browser-test
This was referenced Jul 16, 2024
This was referenced Aug 2, 2024
This was referenced Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Due to the wrong variable being referenced in
#mocha .test.fail::before, the failed test icon (✖) is currently incorrectly colored as#00d6b2instead of#cc0000(light schema) or#ff4444(dark schema). See for example the screenshot posted in comment #4896 (comment).Alternate Designs
n/a - this is clearly a bug fix.
Why should this be in core?
n/a - this is clearly a bug fix.
Benefits
Users may now notice test errors more easily, which makes developers, especially the UX/UI ones, happier.
Possible Drawbacks
n/a - this is clearly a bug fix.
Applicable issues
Regressed since #4896, mentioned 15 days ago (as a review comment) in #4896 (comment), but since there was no response to that, I decided to open this PR.