Doesn't work in IE8 after release v2.4.1

[ConstantineYurevich]

All my tests started to fail after new release in IE8 with the following error:

Object doesn't support this property or method
  at /home/travis/build/driveback/digital-data-manager/node_modules/mocha/mocha.js:11671

[gyandeeps]

Thats because at ~3 spots Object.keys and ~2 spots forEach was used directly rather than checking if the function is present or not.

[boneskull]

Ugh.

[boneskull]

Just load es5-shim until we fix it (very soon)

[gyandeeps]

@yaniswang do you have it for object.keys and [].forEach?

[boneskull]

alright, testing this fix atm.

[gyandeeps]

@boneskull why not use the polyfill for 2 methods (keys and forEach) so that it easy to remove later on when we end IE8 support?

[boneskull]

@gyandeeps rather not add another dependency or monkey with other stuff right now.

[boneskull]

@yurevichcv can you run your tests with this mocha.js file and tell me if you have better results in IE8?

[boneskull]

@gyandeeps anyway, mocha contains a bunch of hand-rolled shims which need replacing. it's a somewhat bigger job than you'd expect

[gyandeeps]

I see. thanks

[boneskull]

downloading an IE8 vm to try it myself

[danielstjules]

@boneskull Your changes work:

Before

After

[boneskull]

v2.4.3 published