recover gracefully if stack is not writable; closes #2528

I have no idea what's causing the error to have a non-writable `stack` property. ¯\_(ツ)_/¯

Author: boneskull

lib/runner.js

@@ -233,9 +233,13 @@ Runner.prototype.fail = function (test, err) {
     err = new Error('the ' + type(err) + ' ' + stringify(err) + ' was thrown, throw an Error :)');
   }
 
-  err.stack = (this.fullStackTrace || !err.stack)
-    ? err.stack
-    : stackFilter(err.stack);
+  try {
+    err.stack = (this.fullStackTrace || !err.stack)
+      ? err.stack
+      : stackFilter(err.stack);
+  } catch (ignored) {
+    // some environments do not take kindly to monkeying with the stack
+  }
 
   this.emit('fail', test, err);
 };
@@ -819,11 +823,13 @@ Runner.prototype.run = function (fn) {
   this.on('end', function () {
     debug('end');
     process.removeListener('uncaughtException', uncaught);
+    process.removeListener('unhandledRejection', uncaught);
     fn(self.failures);
   });
 
   // uncaught exception
   process.on('uncaughtException', uncaught);
+  // process.on('unhandledRejection', uncaught);
 
   if (this._delay) {
     // for reporters, I guess.

lib/utils.js

@@ -794,3 +794,9 @@ exports.stackTraceFilter = function () {
 exports.isPromise = function isPromise (value) {
   return typeof value === 'object' && typeof value.then === 'function';
 };
+
+/**
+ * It's a noop.
+ * @api
+ */
+exports.noop = function () {};

test/runner.spec.js

@@ -6,8 +6,7 @@ var Runner = mocha.Runner;
 var Test = mocha.Test;
 var Hook = mocha.Hook;
 var path = require('path');
-
-function noop () {}
+var noop = mocha.utils.noop;
 
 describe('Runner', function () {
   var suite;
@@ -291,6 +290,21 @@ describe('Runner', function () {
       });
       runner.fail(test, err);
     });
+
+    it('should recover if the error stack is not writable', function (done) {
+      var err = new Error('not evil');
+      Object.defineProperty(err, 'stack', {
+        value: err.stack
+      });
+      var test = new Test('a test', noop);
+
+      runner.on('fail', function (test, err) {
+        err.message.should.equal('not evil');
+        done();
+      });
+
+      runner.fail(test, err);
+    });
   });
 
   describe('.failHook(hook, err)', function () {