re-add stringify during list to appease tests, open for discussion if…

… this is correct behavior
mochajs · Oct 20, 2017 · 760b4db · 760b4db
1 parent 09226eb
commit 760b4db
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/lib/reporters/base.js b/lib/reporters/base.js
@@ -155,10 +155,17 @@ exports.cursor = {
   }
 };
 
-function showDiff(err) {
+function showDiff (err) {
   return err && err.showDiff !== false && sameType(err.actual, err.expected) && err.expected !== undefined;
 }
 
+function stringifyDiffObjs (err) {
+  if (!utils.isString(err.actual) || !utils.isString(err.expected)) {
+    err.actual = utils.stringify(err.actual);
+    err.expected = utils.stringify(err.expected);
+  }
+}
+
 /**
  * Output the given `failures` as a list.
  *
@@ -204,6 +211,7 @@ exports.list = function (failures) {
     }
     // explicitly show diff
     if (showDiff(err)) {
+      stringifyDiffObjs(err);
       escape = false;
       fmt = color('error title', '  %s) %s:\n%s') + color('error stack', '\n%s\n');
       var match = message.match(/^([^:]+): expected/);
@@ -290,10 +298,7 @@ function Base (runner) {
     stats.failures = stats.failures || 0;
     stats.failures++;
     if (showDiff(err)) {
-      if (!utils.isString(err.actual) || !utils.isString(err.expected)) {
-        err.actual = utils.stringify(err.actual);
-        err.expected = utils.stringify(err.expected);
-      }
+      stringifyDiffObjs(err);
     }
     test.err = err;
     failures.push(test);

diff --git a/test/reporters/list.spec.js b/test/reporters/list.spec.js
@@ -192,7 +192,7 @@ describe('List reporter', function () {
 
       Base.cursor = cachedCursor;
     });
-    it('should immediately construct fail strings', function() {
+    it('should immediately construct fail strings', function () {
       var actual = { a: 'actual' };
       var expected = { a: 'expected' };
       var test = {};