Skip to content

Commit 286f457

Browse files
authored
Merge pull request #3014 from awmirantis/bump_20.10-cherry-pick-3003
[bump_20.10] Fix issue where service doesn't roll back
2 parents c9afb5f + 246c62f commit 286f457

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

manager/orchestrator/update/updater.go

+5
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,11 @@ slotsLoop:
280280
wg.Wait()
281281

282282
if !stopped {
283+
// if a delay is set we need to monitor for a period longer than the delay
284+
// otherwise we will leave the monitorLoop before the task is done delaying
285+
if updateConfig.Delay >= monitoringPeriod {
286+
monitoringPeriod = updateConfig.Delay + 1*time.Second
287+
}
283288
// Keep watching for task failures for one more monitoringPeriod,
284289
// before declaring the update complete.
285290
doneMonitoring := time.After(monitoringPeriod)

0 commit comments

Comments
 (0)