image: move image source resolver away from old interface #6330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/dockerfile
area/llb
area/testing
area/dependencies
tonistiigi
force-pushed
the
image-source-metadata
branch
4 times, most recently
from
320bc6b to
15cdfac
Compare
Member
Author
|
Added support for resolving attestationchain into the same PR as it already leaked to the previous commit. In extra commit, I removed reporting the bytes for image manifest. It is a bit inconsistent like this as other blobs report their content, but image manifest data is not really needed to verify the signed attestation chain. |
crazy-max
approved these changes
Nov 5, 2025
ResolveImageConfig was changed to ResolveSourceMetadata long time ago for cross-source implementation but the worker implementation was still using old method name with conversions. Signed-off-by: Tonis Tiigi <[email protected]>
Attestation chain can be used by the client to verify signature identity of the image. Signed-off-by: Tonis Tiigi <[email protected]>
Image manifest content is not needed for signature verification as the verification is against the top index root. Still report image manifest digest for more info about the reported attestation subject but clients need to re-resolve it from the root manifest for signature verification. Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
image-source-metadata
branch
from
bb22687 to
2fc7854
Compare
crazy-max
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResolveImageConfig was changed to ResolveSourceMetadata long time
ago for cross-source implementation but the worker implementation
was still using old method name with conversions.
Additionally, move
Platformfrom mainOptstruct toImageOptandOCIOptstructures as it is only meaningful for these types and keeping them in main struct would mean whole struct needs to be passed to the underlying source implementation.