vendoring: try to catch more vendoring issues & fixup an existing one #303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment vendor.conf is missing entries for
github.com/tonistiigi/llb-gobuild
and
github.com/morikuni/aec
due in part because of a combination ofLK4D4/vndr#62 and LK4D4/vndr#63.
The issue vndr#63 (related to lack of
github.com/morikuni/aec
) can be workedaround by removing the vendor directory before rerunning
vndr
, so do so.Due to vndr#62 the issue with
github.com/tonistiigi/llb-gobuild
cannot bedetected at the moment, but pass
-strict
tovndr
in anticipation of a fixthere.
This will make the CI fail on this PR (I hope). Once it has done so I will push an extra patch which fixes things by adding the
github.com/morikuni/aec
entry tovendor.conf
.I will not add the
github.com/tonistiigi/llb-gobuild
since the userexamples/gobuild/main.go
is marked// +build ignore
, with currentvndr
that produces a warning (harmless due too LK4D4/vndr#62 even we add-strict
here) but with newervndr
it does not.