Skip to content

Commit 49259d7

Browse files
committed
use isvalid for determining validity and remove vtproto from buildctl
Signed-off-by: Jonathan A. Sternberg <[email protected]>
1 parent f4883ef commit 49259d7

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

client/llb/marshal.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import (
66
"github.com/containerd/platforms"
77
"github.com/moby/buildkit/solver/pb"
88
digest "github.com/opencontainers/go-digest"
9+
"google.golang.org/protobuf/proto"
910
)
1011

1112
// Definition is the LLB definition structure with per-vertex metadata entries
@@ -49,7 +50,7 @@ func (def *Definition) Head() (digest.Digest, error) {
4950
last := def.Def[len(def.Def)-1]
5051

5152
var pop pb.Op
52-
if err := pop.UnmarshalVT(last); err != nil {
53+
if err := proto.Unmarshal(last, &pop); err != nil {
5354
return "", err
5455
}
5556
if len(pop.Inputs) == 0 {
@@ -74,7 +75,7 @@ func ReadFrom(r io.Reader) (*Definition, error) {
7475
return nil, err
7576
}
7677
var pbDef pb.Definition
77-
if err := pbDef.UnmarshalVT(b); err != nil {
78+
if err := proto.Unmarshal(b, &pbDef); err != nil {
7879
return nil, err
7980
}
8081
var def Definition

cmd/buildctl/build.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import (
3030
"github.com/pkg/errors"
3131
"github.com/urfave/cli"
3232
"golang.org/x/sync/errgroup"
33+
"google.golang.org/protobuf/proto"
3334
)
3435

3536
var buildCommand = cli.Command{
@@ -126,7 +127,7 @@ func read(r io.Reader, clicontext *cli.Context) (*llb.Definition, error) {
126127
if clicontext.Bool("no-cache") {
127128
for _, dt := range def.Def {
128129
var op pb.Op
129-
if err := op.UnmarshalVT(dt); err != nil {
130+
if err := proto.Unmarshal(dt, &op); err != nil {
130131
return nil, errors.Wrap(err, "failed to parse llb proto op")
131132
}
132133
dgst := digest.FromBytes(dt)

0 commit comments

Comments
 (0)