Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shallow comparer #2151

Merged
merged 2 commits into from
Oct 12, 2019
Merged

Shallow comparer #2151

merged 2 commits into from
Oct 12, 2019

Conversation

xaviergonz
Copy link
Contributor

@xaviergonz xaviergonz commented Oct 11, 2019

  • Added unit tests
  • Updated changelog
  • Updated /docs. For new functionality, at least API.md should be updated
  • Added typescript typings
  • Verified that there is no significant performance drop (npm run perf)

Fixes #1561

Adds comparer.shallow for shallow comparisons of objects/arrays

Will do a backport when/if accepted

@coveralls
Copy link

coveralls commented Oct 11, 2019

Coverage Status

Coverage increased (+0.007%) to 93.388% when pulling 9005817 on shallow-comparer into 0502539 on master.

Copy link
Contributor

@danielkcz danielkcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't reformat changelog :)

Otherwise, I suppose it looks good given you made a new test and existing ones are passing. But I would rather let others to decide as I don't use these advanced features.

@xaviergonz
Copy link
Contributor Author

The reformatting was actually done by husky on commit hook :-/
I have to actually use --no-verify on commit to skip husky so it won't get reformatted, but I'll do it

@danielkcz
Copy link
Contributor

Sorry, I guess that's my fault, I've changed lint-staged config to include md (for docs), but the actual prettier script is formatting docs folder only. I suppose it's not entirely wrong to have the changelog formatted as well, I will take care of in a separate PR.

@xaviergonz
Copy link
Contributor Author

No worries, I guess it wouldn't hurt to have a PR that basically runs prettier over everything :)

@mweststrate mweststrate merged commit 92cc3e8 into master Oct 12, 2019
@danielkcz danielkcz deleted the shallow-comparer branch October 12, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: comparer.shallow (or shallowArray)
5 participants