Allow Symbol keys in observable maps (fixes #1925) #1930
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-pages
branch. Please refer to this PR). For new functionality, at least API.md should be updatednpm run perf
)@mweststrate you mentioned
safeStringify
in #1925, I couldn't find that - looks like it's a function in the mobx-state-tree codebase?I've written a separate key stringification function instead. Here it actually doesn't use JSON.stringify, because JSON can't represent symbols, and they're normally omitted from JSON stringified objects. For the same reason, I've also preserved symbol-ness in
toPOJO
here, instead of stringifying them, which feels correct, and helpfully means we get the correct behaviour (symbol keys omitted) intoJSON
here too.