Fix toStringTag return type for observable Maps and Sets #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any news on this? This bug prevents us from using the latest version including critical bugfixes for IE 11. A browser we (sadly) need to target in our application. |
|
Merged, releasing soon! |
|
Released as 4.9.4! Sorry for the delay! |
1 similar comment
|
Released as 4.9.4! Sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes (restores) the return type of the
Symbol.toStringTagmethod of observable maps and sets to return either"Map"or"Set".This fixes the following TypeScript errors:
See 4a65b50 for parts of changes causing this error.
Current workaround is to use
4.9.1where this regression was not present.