Improve flow() typing #1825
Improve flow() typing #1825
Conversation
|
Impact: before this MR, flow() only need a generic type when the passed function does not have any parameter. Now, it's always required (for a good reason). |
src/api/flow.ts
Outdated
| export function flow(generator: Function) { | ||
| export function flow<T, U extends any[]>( | ||
| generator: (...args: U) => FlowIterator<any> | ||
| ): CancellablePromise<U> { |
There was a problem hiding this comment.
Why <U>? And why CancellablePromise instead of function?
There was a problem hiding this comment.
No significant meaning here. It can also be changed to <R, A> to follow the previous naming.
There was a problem hiding this comment.
No, it cannot. Right result type is (...args: U) => CancellablePromise<any>
There was a problem hiding this comment.
You're right, I missed the () => part. Strange that no tests are failing.
edit: nvm, the tests are in .js
|
There's a way to make flow properly detect the return argument as well (except when the return argument is a promise, but that can be circumvented with a fake function such as castFlowReturn or similar) |
src/api/flow.ts
Outdated
| export function flow(generator: Function) { | ||
| export function flow<T, U extends any[]>( | ||
| generator: (...args: U) => FlowIterator<any> | ||
| ): (...args: U) => CancellablePromise<U> { |
See: #1816