Update typings to allow flow to take async generators - async function* - MobX 4 #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flow already supports async generators that yield promises, just changing typings to allow it to Also changing from IterableIterator to Iterator: IterableIterator implements Iterator and adds Symbol.iterator property. Because mobx does not use Symbol.iterator property, it's not necessary to use IterableIterator.
Obi-Dann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flowalready supports async generators yielding Promises, just changing typings to allow it.Also changing from
IterableIteratortoIterator:IterableIteratorimplementsIteratorwith the addition of[Symbol.iterator]property.Because
mobxdoes not use[Symbol.iterator]property, it's not necessary to useIterableIterator.