Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update object api set to write through parent mobx administrator #1514

Merged
merged 1 commit into from
Apr 26, 2018

Conversation

quanganhtran
Copy link
Member

This PR is to address #1512

  • Added unit tests
  • Updated changelog
  • Updated docs (either in the description of this PR as markdown, or as separate PR on the gh-pages branch. Please refer to this PR). For new functionality, at least API.md should be updated
  • Added typescript typings
  • Verified that there is no significant performance drop (npm run perf)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 93.007% when pulling 4ccf47c on quanganhtran:observe-set into dbe4c93 on mobxjs:master.

@mweststrate
Copy link
Member

Great analysis and fix @quanganhtran! Interested in becoming member of the MobX org? That makes it easier to create PRs and branches directly on the repo in the future.

P.S., you live in Helsinki? Are you attending React Finland ATM?

@mweststrate mweststrate merged commit be5eb38 into mobxjs:master Apr 26, 2018
@quanganhtran quanganhtran deleted the observe-set branch April 26, 2018 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants