Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toJS different output from 4.8->4.9 #1875

Closed
timothyallan opened this issue Jan 22, 2019 · 2 comments
Closed

toJS different output from 4.8->4.9 #1875

timothyallan opened this issue Jan 22, 2019 · 2 comments
Labels

Comments

@timothyallan
Copy link

As discussed on Gitter:
Given @observable meta = new Map<string, any>();

4.8 toJS outputs a js object, as it has been for ages.
https://codesandbox.io/s/pwrz28jzx7

4.9 toJS outputs an observable map.
https://codesandbox.io/s/jp0j98y0yy

There wasn't supposed to be any changes according to the changelog, so I'm guessing that something is borked.

@mweststrate
Copy link
Member

Thanks for reporting! Fixed in 4.9.1. This was a regression introduced by a merge indeed! (Note that it depends on the module bundler whether the issue actually manifested)

@lock
Copy link

lock bot commented Jul 21, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or questions.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants