Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting an undefined property breaks change tracking #1796

Closed
vilicvane opened this issue Nov 2, 2018 · 2 comments
Closed

Deleting an undefined property breaks change tracking #1796

vilicvane opened this issue Nov 2, 2018 · 2 comments
Labels
🐛 bug

Comments

@vilicvane
Copy link

vilicvane commented Nov 2, 2018 •
edited
Loading

Repro:

https://runkit.com/embed/klb7retpaks5

Possibly related:

#1730
@urugator
Copy link
Collaborator

urugator commented Nov 2, 2018 •
edited
Loading

Perhaps following line usually leads to reportChanged, but since undefined === undefined, it does not?
https://github.com/mobxjs/mobx/blob/master/src/types/observableobject.ts#L215
EDIT: not sure why reintroduction wouldn't work though

The same repro in codesandbox

@lock
Copy link

lock bot commented Jul 21, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or questions.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐛 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vilicvane @mweststrate @urugator