Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow typing of observable.map is not updated for MobX 4 #1500

Closed
3 tasks done
quanganhtran opened this issue Apr 14, 2018 · 1 comment
Closed
3 tasks done

Flow typing of observable.map is not updated for MobX 4 #1500

quanganhtran opened this issue Apr 14, 2018 · 1 comment

Comments

@quanganhtran
Copy link
Member

quanganhtran commented Apr 14, 2018 •
edited
Loading

I have a:

  1. Issue:
  • Did you check this issue wasn't filed before?
  • State the versions of MobX and relevant libraries: MobX 4

Since MobX 4 uses ES6 Map, all typings related to Map<T> has been updated to Map<K, V> except observable.map. This introduces Flow error with Flow 0.69

I have prepared a PR to update the definition.
@quanganhtran quanganhtran mentioned this issue Apr 14, 2018
Merged
@mweststrate
Copy link
Member

Merged! Will release soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mweststrate @quanganhtran