Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make deep NaN === deep NaN for computed values when using compareStructural #1249

Merged
merged 2 commits into from
Nov 23, 2017

Conversation

Ulmanb
Copy link
Contributor

@Ulmanb Ulmanb commented Nov 21, 2017

There seemed to be an inconsistent behavior where NaN === NaN but deep NaN !== NaN.
I think @benjamingr talked with you about it.

PR checklist:

  • Added unit tests
  • Verified that there is no significant performance drop (npm run perf) - it does seem to add around 1-3 second on my machine, not sure if this is significant.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 94.653% when pulling 6052a7c on Ulmanb:master into 7fdf5f3 on mobxjs:master.

@benjamingr
Copy link
Member

@mweststrate this is the one we discussed.

@mweststrate
Copy link
Member

Thanks for noticing & PR, @Ulmanb & @benjamingr!

@mweststrate mweststrate merged commit 307405a into mobxjs:master Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants