Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve flow typings for observable #1231

Merged

Conversation

halbgut
Copy link
Contributor

@halbgut halbgut commented Nov 5, 2017

This is basically just copied from the typescript definition and slightly modified to match the flow syntax.

This is basically just copied from the typescript definition and
slightly modified to match the flow syntax.
@halbgut halbgut force-pushed the feature/improve-flow-typings-for-observable branch from 641e268 to f43dbf6 Compare November 5, 2017 14:46
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.651% when pulling f43dbf6 on Kriegslustig:feature/improve-flow-typings-for-observable into b7fef45 on mobxjs:master.

@halbgut
Copy link
Contributor Author

halbgut commented Nov 22, 2017

CI failure because of auto cancellation. Can't really do anything about this. The tests pass locally.

This job was cancelled because the "Auto Cancellation" feature is currently enabled, and a more recent build (#1232) for pull request #1231 came in while this job was waiting to be processed.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.686% when pulling bb47f40 on Kriegslustig:feature/improve-flow-typings-for-observable into de51957 on mobxjs:master.

@mweststrate
Copy link
Member

Thanks a lot for your effort!

@mweststrate mweststrate merged commit dddecfc into mobxjs:master Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants