Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Index Type for property name in intercept #1119

Merged
merged 2 commits into from
Aug 8, 2017
Merged

Use Index Type for property name in intercept #1119

merged 2 commits into from
Aug 8, 2017

Conversation

smithgeek
Copy link
Contributor

Use an index type for the property name argument when using intercept for better type checking.

Use an index type for the property name argument when using intercept for better type checking.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.671% when pulling e8abf1c on smithgeek:patch-1 into aa412a9 on mobxjs:master.

@capaj
Copy link
Member

capaj commented Aug 8, 2017

@smithgeek sorry I've merged codestyle change which affected the whole codebase. Would you be as kind and rebase your change? LGTM so I'd merge it when you do.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.682% when pulling c4441bf on smithgeek:patch-1 into 8d4b0e3 on mobxjs:master.

@mweststrate
Copy link
Member

Thanks!

@mweststrate mweststrate merged commit 3d47b59 into mobxjs:master Aug 8, 2017
@mweststrate
Copy link
Member

Merged as part of 3.3.0

@smithgeek smithgeek deleted the patch-1 branch October 20, 2017 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants