Introduce prettier to keep the format of the codebase consistent #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realityforge
force-pushed
the
IntroducePrettier
branch
from
7abea62
to
4482060
Compare
realityforge
force-pushed
the
IntroducePrettier
branch
from
4482060
to
cc14442
Compare
capaj
reviewed
Aug 7, 2017
| "lint-staged": { | ||
| "*.{ts,tsx,js,jsx}": [ | ||
| "prettier --write --print-width 100 --tab-width 4 --no-semi", |
There was a problem hiding this comment.
@mweststrate are you okay with no semi and tab with 4?
|
Yep! Sorry for not responding earlier
Op ma 7 aug. 2017 10:18 schreef Jiri Spac <[email protected]>:
… ***@***.**** commented on this pull request.
------------------------------
In package.json
<#1103 (comment)>:
> \ No newline at end of file
+ ],
+ "lint-staged": {
+ "*.{ts,tsx,js,jsx}": [
+ "prettier --write --print-width 100 --tab-width 4 --no-semi",
@mweststrate <https://github.com/mweststrate> are you okay with no semi
and tab with 4?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1103 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABvGhJAMIcsxgck-AAy6ZIl0vsM3DQZsks5sVshngaJpZM4Ocq7o>
.
|
|
awesome. Since this builds fine, I'll merge it. |
|
Am I missing something or is there a dependency to |
|
@phiresky yeah we're missing husky. We have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address issue #1060.
In short it introduces the
prettierandlint-stageddependencies and setups the same tasks and configuration as in mobxjs/mobx-state-tree. The prettier was also run across the codebase to ensure it aligns with the new codestyle.It should be notes that the codestyle in
mobx-state-treeis not the same as in this codebase and thus this commit introduces a lot of changes. If you prefer I could align the rules used by prettier to more closely match this repository to minimize the amount of changes in the pull request.