More cleanup!

Author: mweststrate

CHANGELOG.md

@@ -29,6 +29,7 @@
 * custom atoms: `reportObserved` outside tracking context won't trigger changes
 * map `.entries()`, `.values()` and `.keys()` now properly return iterators. use `values(m)` or `keys(m)` or `Array.from(m)` to get the old behavior
 * the option `struct` for computed values is deprecated, use `compareStructural` indeed
+* `isModifierDescriptor` is no longer exposed
 
 ## Non breaking changes
 

src/api/object-api.ts

@@ -7,8 +7,7 @@ import {
 } from "../types/observableobject"
 import { isObservableArray, IObservableArray } from "../types/observablearray"
 import { fail, invariant } from "../utils/utils"
-import { isModifierDescriptor } from "../mobx"
-import { deepEnhancer } from "../types/modifiers"
+import { deepEnhancer, isModifierDescriptor } from "../types/modifiers"
 import { startBatch, endBatch } from "../core/observable"
 
 export function keys(obj: IObservableObject): string[]

src/core/action.ts

@@ -83,10 +83,6 @@ export function useStrict(strict: boolean): void {
     globalState.allowStateChanges = !strict
 }
 
-export function isStrictModeEnabled(): boolean {
-    return globalState.strictMode
-}
-
 export function allowStateChanges<T>(allowStateChanges: boolean, func: () => T): T {
     const prev = allowStateChangesStart(allowStateChanges)
     let res: T

src/mobx.ts

@@ -25,7 +25,7 @@ export { spy } from "./core/spy"
 export { IComputedValue } from "./core/computedvalue"
 
 export { IEqualsComparer, comparer } from "./types/comparer"
-export { IModifierDescriptor, IEnhancer, isModifierDescriptor } from "./types/modifiers"
+export { IModifierDescriptor, IEnhancer } from "./types/modifiers"
 export { IInterceptable, IInterceptor } from "./types/intercept-utils"
 export { IListenable } from "./types/listen-utils"
 

test/base/api.js

@@ -28,7 +28,6 @@ test("correct api should be exposed", function() {
             "isComputed",
             "isComputedProp",
             "_isComputingDerivation",
-            "isModifierDescriptor", // TODO: drop
             "isObservable",
             "isObservableArray",
             "isObservableMap",

test/base/observables.js

@@ -1354,7 +1354,6 @@ test("atom events #427", () => {
     var runs = 0
 
     var a = mobx.createAtom("test", () => start++, () => stop++)
-    // TODO: fix: Atom should throw on this! (or have a handler to react to untracked reads)
     expect(a.reportObserved()).toEqual(false)
 
     expect(start).toBe(0)

test/base/typescript-tests.ts

@@ -1151,8 +1151,8 @@ test("803 - action.bound and action preserve type info", () => {
 
     thingThatAcceptsCallback(
         action((elem: any) => {
-            // TODO: ideally, type of action would be inferred!
-            // console.log(elem.x) // x is boolean
+            // ideally, type of action would be inferred!
+            console.log(elem.x) // x is boolean
         })
     )