Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No server-side CAPTCHA validation on registration page #2062

Open
gainsley opened this issue Mar 23, 2022 · 0 comments
Open

No server-side CAPTCHA validation on registration page #2062

gainsley opened this issue Mar 23, 2022 · 0 comments

Comments

@gainsley
Copy link
Contributor

The UI implements captcha for new user registrations, but it is browser side only. It is recommended to have the UI captcha generate a token which can then be verified by the Master Controller before allowing the user create to happen. This, along with the rate limiter, will help prevent bots from spamming new user creates.

This is only valid for user create requests from a web browser going through our UI interface. For mcctl and direct API calls, we can just drop support for the current unauthenticated user create, but also add a restricted-user-create which requires admin authentication. The restricted user create will be used for unit, e2e, and regression testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant