Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Target for Enclave Builds #1062

Open
jcape opened this issue Sep 23, 2021 · 0 comments
Open

Custom Target for Enclave Builds #1062

jcape opened this issue Sep 23, 2021 · 0 comments
Assignees
Labels
build Issues related to the build system

Comments

@jcape
Copy link
Contributor

jcape commented Sep 23, 2021

One of the recurring themes that comes up is the use of a custom target for our SGX enclaves. We've discussed this a long time ago, but decided against it because it was more complexity than it was worth at the time.

However, as our dependencies get more sophisticated, it's worth revisiting. If we had a custom target, e.g x86_64-mobilecoin-none-sgx , we could:

  1. Delete the mc-crypto-rand crate, since getrandom can be configured to use rdrand.
  2. Delete our fork of cpufeatures, since it does the right thing and uses target features when target_env = sgx.

The downside of this is that we can never use a stable rust for enclave builds. If we built an target, this could be useful. It may not be a practical issue, since allocators are not stabilized, but it's worth considering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build system
Projects
Status: Todo
Development

No branches or pull requests

3 participants