Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

callback firing before expected. #15

Closed
MarcoMedrano opened this issue Apr 16, 2018 · 4 comments
Closed

callback firing before expected. #15

MarcoMedrano opened this issue Apr 16, 2018 · 4 comments

Comments

@MarcoMedrano
Copy link

Hi it is a very cool lib!! Just trying current version. the issue is callback function is fired almost immediately rather than at the end of the animation.

@moarwick
Copy link
Owner

hi @MarcoMedrano. sorry, just noticed the issue. can you tell me your props and which browser? the callback should be fired after start delay + (anim duration * iterations), but in IE it falls back to Tween.js which has its own onComplete...

@rmaksim
Copy link

rmaksim commented Apr 30, 2018

Hello.
I have same issue. (Google Chrome 66...)

duration={xxx}
playback is not defined

static defaultProps = {
    ...
    playback: 'forwards',
}
...
let numOfRepeats = parseInt(playback, 10) || 0
...
setTimeout(..., startDelay + duration * (numOfRepeats) )

0 + xxx * 0 = 0

@moarwick
Copy link
Owner

moarwick commented May 3, 2018

hmm, that indeed looks wrong! checking...

@moarwick moarwick closed this as completed May 3, 2018
@moarwick moarwick reopened this May 3, 2018
@moarwick
Copy link
Owner

moarwick commented May 3, 2018

duh, definitely had an issue there but should be fixed in 0.8.4, see Demo

@moarwick moarwick closed this as completed May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants