Merge branch 'main' into fix-nk-cal-factor

Author: myd7349

.pre-commit-config.yaml

@@ -1,7 +1,7 @@
 repos:
   # Ruff mne
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.14.1
+    rev: v0.14.2
     hooks:
       - id: ruff-check
         name: ruff lint mne
@@ -82,7 +82,7 @@ repos:
 
   # zizmor
   - repo: https://github.com/woodruffw/zizmor-pre-commit
-    rev: v1.15.2
+    rev: v1.16.0
     hooks:
       - id: zizmor
 

doc/changes/dev/13466.bugfix.rst

@@ -0,0 +1 @@
+Fix bug with :func:`mne.add_reference_channels` not working correctly when passing more than one channel name, by `Michael Straube`_.

mne/_fiff/reference.py

@@ -316,7 +316,7 @@ def add_reference_channels(inst, ref_channels, copy=True):
             "unit_mul": FIFF.FIFF_UNITM_NONE,
             "unit": FIFF.FIFF_UNIT_V,
             "coord_frame": FIFF.FIFFV_COORD_HEAD,
-            "loc": ref_dig_array,
+            "loc": ref_dig_array.copy(),
         }
         inst.info["chs"].append(chan_info)
         inst.info._update_redundant()

mne/_fiff/tests/test_reference.py

@@ -744,6 +744,10 @@ def test_add_reference():
     ref_data, _ = raw[[ref_idx, ref_idy]]
     assert_array_equal(ref_data, 0)
 
+    loc1 = raw.info["chs"][ref_idx]["loc"]
+    loc2 = raw.info["chs"][ref_idy]["loc"]
+    assert loc1 is not loc2
+
     # add reference channel to epochs
     raw = read_raw_fif(fif_fname, preload=True)
     events = read_events(eve_fname)