Aggregate live bytes info in on_gc_finished #1292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wks
reviewed
Mar 28, 2025
src/scheduler/scheduler.rs
Outdated
Comment on lines
562
to
565
| let mut stats = mmtk.state.live_bytes_in_last_gc.borrow_mut(); | ||
| *stats = mmtk.aggregate_live_bytes_in_last_gc(live_bytes); | ||
| // Logging | ||
| for (space_name, &stats) in stats.iter() { |
Collaborator
There was a problem hiding this comment.
There are two different variables with the same name stats, one defined on line 562 by the let mut, and the other on line 565 by the &stats in the for loop. It is a bit confusing. I suggest renaming the former to live_bytes_in_last_gc, map or guard, whatever makes sense.
Member
Author
There was a problem hiding this comment.
Thanks for spotting this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the call to
aggregate_live_bytes_in_last_gcfrom theReleasework packet toon_gc_finished. Spaces may do release work in parallel with theReleasework packet, andaggregate_live_bytes_in_last_gcaccesses reserved pages of spaces. This leads to a data race. We observed the reserved pages in the collected live bytes stats to be larger than the actual reserved pages at the end of a GC, as some pages were not released yet.