Skip to content

Conversation

@udesou
Copy link
Contributor

@udesou udesou commented Jul 10, 2024

If an object dies, we need to make sure his pin bit gets cleared. This PR enables clearing the pin bits when sweeping - clearing the whole block when super::BLOCK_ONLY is true, or at line granularity when a line is not marked.
I've only added it to the immix policy, since for everything else pinning is either unsupported or it's a NOP.

@udesou udesou requested review from qinsoon and wks July 10, 2024 01:15
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should only do the bulk clearing if the pinning bit is in side metadata.

BTW, if it is convenient, you can add the code for clearing pinning bits for CopySpace. Sorry. We can't pin things in the CopySpace.

Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@udesou udesou added this pull request to the merge queue Jul 12, 2024
Merged via the queue into mmtk:master with commit 55e4017 Jul 12, 2024
@udesou udesou deleted the fix/clear-pin-bits branch July 12, 2024 04:20
k-sareen pushed a commit to k-sareen/mmtk-core that referenced this pull request Jul 31, 2024
If an object dies, we need to make sure his pin bit gets cleared. This
PR enables clearing the pin bits when sweeping - clearing the whole
block when `super::BLOCK_ONLY` is true, or at line granularity when a
line is not marked.
I've only added it to the immix policy, since for everything else
pinning is either unsupported or it's a NOP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants