Skip to content

Commit 4d3c523

Browse files
committed
Minor changes
Extract canary version to an environment variable. Do not use secret when checking out ci-perf-kit because it is a public repo now. Add a name to the "branch" action.
1 parent 7ac891d commit 4d3c523

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

.github/workflows/perf-regression-ci.yml

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,12 @@ jobs:
9797
openjdk-perf-regression:
9898
runs-on: [self-hosted, Linux, freq-scaling-off]
9999
timeout-minutes: 1440
100+
env:
101+
# This version will be used as the canary version, and will be used to checkout both
102+
# `mmtk-core` and `mmtk-openjdk`. We choose one release version for this purpose. We may
103+
# change to another release version if necessary, or introduce a mechanism to dynamically
104+
# choose the canary in the future.
105+
CANARY_VERSION: "v0.28.0"
100106
steps:
101107
# checkout latest versions
102108
- name: Checkout MMTk Core (latest)
@@ -119,21 +125,17 @@ jobs:
119125
repository: mmtk/ci-perf-kit
120126
ref: "0.8.0"
121127
path: ci-perf-kit
122-
token: ${{ secrets.CI_ACCESS_TOKEN }}
123128
submodules: true
124129
# checkout canary versions.
125-
# Currently using a release version.
126-
# We need a script to find the latest stable version from a list of tags (`git tags -l`).
127-
# Alternatively, we may use the latest commit in the last epoch once we stablize the idea of epoch.
128130
- name: Checkout MMTk Core (canary)
129131
uses: actions/checkout@v4
130132
with:
131-
ref: "v0.28.0"
133+
ref: $CANARY_VERSION
132134
path: canary/mmtk-core
133135
- name: Checkout OpenJDK Binding (canary)
134136
uses: actions/checkout@v4
135137
with:
136-
ref: "v0.28.0"
138+
ref: $CANARY_VERSION
137139
repository: mmtk/mmtk-openjdk
138140
path: canary/mmtk-openjdk
139141
- name: Checkout OpenJDK (canary)
@@ -155,7 +157,8 @@ jobs:
155157
rm -rf mmtk-openjdk/repos/openjdk/build
156158
popd
157159
done
158-
- id: branch
160+
- name: Setup branch name
161+
id: branch
159162
# we cannot use env vars in action input (the deploy step). So put the env var to this step's outputs.
160163
run: echo "branch_name=$(echo ${GITHUB_REF#refs/heads/} | sed 's/\//_/g')" >> $GITHUB_OUTPUT
161164
# run

0 commit comments

Comments
 (0)